Skip to content

[px4] bug-fix: MavLinkMultirotorApi::sendHILSensor() - #2556

Merged
Ratnesh Madaan (madratman) merged 1 commit into
microsoft:masterfrom
madratman:PX4/bug_fix_sendHILSensor
Apr 29, 2020
Merged

[px4] bug-fix: MavLinkMultirotorApi::sendHILSensor()#2556
Ratnesh Madaan (madratman) merged 1 commit into
microsoft:masterfrom
madratman:PX4/bug_fix_sendHILSensor

Conversation

@madratman

@madratman Ratnesh Madaan (madratman) commented Apr 9, 2020

Copy link
Copy Markdown
Contributor

See these comments for reported error #2477 (comment), #2477 (comment), #2549 (comment)

See this comment #2477 (comment) for details on bug

PR updates update last_hil_sensor_time_ in the case no actuator control is received, so future messages are not affected

@madratman
[px4] bug-fix: MavLinkMultirotorApi::sendHILSensor() - update last_hi…
e659318 
…l_sensor_time_ if no actuator control is recieved
@madratman Ratnesh Madaan (madratman) mentioned this pull request Apr 9, 2020
Closed
@madratman
Ratnesh Madaan (madratman) marked this pull request as draft April 9, 2020 14:18
@bys1123

斯东Stone (bys1123) commented Apr 19, 2020

Copy link
Copy Markdown
Contributor

image
Trying to test, but can't succeed connect px4 in unreal editor, don't know what I did wrong.

@TomSeestern

TomSeestern (TomSeestern) commented Apr 27, 2020 •
edited
Loading

Copy link
Copy Markdown

Similar problem here. PR seems to be interfering with Mavlink/PX4 communications.

Works with the current Version of the PX4 Firmware (v1.11.0) on Ubuntu 18.04.4

@bys1123

斯东Stone (bys1123) commented Apr 27, 2020

Copy link
Copy Markdown
Contributor

TomSeestern (@TomSeestern) How you fix this, could you help me please?

@TomSeestern

TomSeestern (TomSeestern) commented Apr 27, 2020

Copy link
Copy Markdown

I just git pull'ed the current Firmware Version from PX4 and that did the trick.

Also make sure settings.json from AirSim contains the TCP Port for PX4
my settings.json:

{
  "SettingsVersion": 1.2,
  "SeeDocsAt": "https://github.com/Microsoft/AirSim/blob/master/docs/settings.md",
  "SimMode": "Multirotor",
  "DefaultVehicleConfig": "PX4",
  "Vehicles": {
    "PX4": {
            "VehicleType": "PX4Multirotor",
            "UseSerial": false,
            "UseTcp": true,
            "TcpPort": 4560,
            "ControlPort": 14580,
            "params": {
                    "NAV_RCL_ACT": 0,
                    "NAV_DLL_ACT": 0,
                    "LPE_LAT": 47.3977508,
                    "LPE_LON": 8.5456074,
                    "COM_OBL_ACT": 1
                }
        }
  },
  "OriginGeopoint": {
    "Latitude": 47.3977508,
    "Longitude": 8.5456074,
     "Altitude": 0
    }
}

lovettchris
Chris Lovett (lovettchris) approved these changes Apr 29, 2020
View reviewed changes

@lovettchris Chris Lovett (lovettchris) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good fix, thanks!

@madratman
Ratnesh Madaan (madratman) marked this pull request as ready for review April 29, 2020 19:58
@madratman

Ratnesh Madaan (madratman) commented Apr 29, 2020

Copy link
Copy Markdown
Contributor Author

Thanks Chris Lovett (@lovettchris) for review and the new PR! I'll merge this now.

@madratman
Ratnesh Madaan (madratman) merged commit 089645c into microsoft:master Apr 29, 2020
@madratman

Ratnesh Madaan (madratman) commented Apr 29, 2020

Copy link
Copy Markdown
Contributor Author

Thanks TomSeestern (@TomSeestern), 斯东Stone (@bys1123) for testing it out as well!

Ratnesh Madaan (madratman) added a commit to ironclownfish/AirSim that referenced this pull request May 2, 2020
@madratman
[px4] bug-fix: MavLinkMultirotorApi::sendHILSensor() - update last_hi…
f914153 
…l_sensor_time_ if no actuator control is recieved (microsoft#2556)
@ibrahim-aydin I. Aydin (ibrahim-aydin) mentioned this pull request May 12, 2020
Merged
@lberridge1992 lberridge1992 mentioned this pull request Oct 29, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@lovettchris Chris Lovett (lovettchris) lovettchris approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@madratman @bys1123 @TomSeestern @lovettchris